Skip to content

fix(sdk): include persisted IDs in agent message notifications - #38

Merged
matej21 merged 1 commit into
mainfrom
fix/chat-notification-identity
Sep 15, 2026
Merged

matej21 merged 1 commit into
mainfrom
fix/chat-notification-identity

Conversation

@matej21

@matej21 matej21 commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Include the persisted chat message ID in agentMessage notifications from both tellUser and XML communication.
  • Let clients reconcile live notifications with stored history without guessing from content or timestamps.
  • Assert that notification IDs match the stored message IDs in both integration paths.

Compatibility

The notification gains a messageId field; persisted events and message IDs are unchanged. Existing consumers that ignore additional fields continue to work. Consumers constructing typed agentMessage payloads must include the field.

Verification

  • 40 user-chat integration tests passed.
  • Clean monorepo TypeScript build passed.
  • SDK test typecheck passed.
  • Biome lint and git diff --check passed.

No release or deployment performed.

@matej21
matej21 merged commit b0fc562 into main Sep 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant