Skip to content

revert(runtime): defer server preview and browser commit - #548

Merged
Charles Hudson (phobetron) merged 1 commit into
mainfrom
revert/defer-runtime-preview-release
Oct 16, 2026
Merged

Charles Hudson (phobetron) merged 1 commit into
mainfrom
revert/defer-runtime-preview-release

Conversation

@phobetron

@phobetron Charles Hudson (phobetron) commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Defer the complete server-preview/browser-commit change from #535 until after the current release. This reverts 4169fb0119371b3287835dfab4a190af5c1bb8c9 across its 239 files, including SDK behavior and APIs, tests, reference implementations, documentation, SDK knowledge, development harnesses, CI changes, and bundle budgets.

Later commits are preserved, including the React Native toolchain upgrades in #546 and ExO parent variant attribution in #547. Applying the original #535 patch to this revert produces exactly the source tree at 28f3f7afcd9e4fbc990182d73044d0211669704f.

Release sequence

  1. Merge this revert before release PR chore(repo): release packages for main #527.
  2. Let Release Please refresh chore(repo): release packages for main #527 and verify its source, versions, and notes before merging it. The approved release-message override on feat(runtime)!: preview on server and commit in browser #535 classifies the deferred commit as a non-breaking chore; the original description is preserved. The installed Release Please parser confirms that the override removes its breaking-feature classification.
  3. Wait for the intended release publications to finish.
  4. Retarget/rebase the companion restoration draft onto main, review its checks, and merge it only for a subsequent release.

The companion restoration is draft PR #549, on branch restore/runtime-preview-after-release. Its draft initially targets this revert branch so its diff is visible before this revert merges. This revert is independently useful and does not require the restoration PR to merge.

CI impact

Changed paths Packages and maintained consumers Triggered validation
Universal, Node, Web, React, Next.js, React Native, and native SDK paths Complete published SDK graph, native JS bridge, and all Web/native implementation families Build/package/size, typecheck, lint, unit tests, Android unit/packaging, Swift build, and all path-filtered Web/native E2E jobs
Guides, concepts, authoring inputs, and SDK knowledge Documentation for restored public contracts Knowledge, guides, Fern export, and formatting checks
Implementation sources, tests, and E2E tooling Node SSR, Node/Web, Angular, Next.js App/Pages/Edge, React Native, and iOS Implementation install/lint/typecheck and applicable Playwright/Detox/Maestro/XCUITest jobs

No lockfile or release manifest changes are included.

Local validation

  • Package typechecks and unit suites passed: 1,268 tests. The normal pre-push hook also passed all changed implementation typechecks and unit-test scripts after refreshing local SDK packages.
  • pnpm lint, pnpm implementation:lint, pnpm format:fix, pnpm knowledge:check, pnpm guides:check, and pnpm fern:check passed.
  • Clean package build, pnpm build:pkgs, aggregate pnpm size:report, and aggregate pnpm size:check passed.
  • Exact source-tree round trip passed: applying feat(runtime)!: preview on server and commit in browser #535 to the reverted tree reproduces current main byte for byte.
  • Focused Node/Web Playwright validation passed: 12 tests across Chromium, Firefox, and WebKit. Started the maintained app runner, confirmed /user/someone was responding, then ran pnpm --dir implementations/node-sdk+web-sdk exec playwright test displays-identified-user-variants.spec.ts and cleaned up through serve:stop.
  • Full Web/native E2E coverage and native unit/build checks remain CI validation targets; they have not all been run locally.

Review the triggered CI checks before merging this revert. The restoration PR remains a draft until the current release has been published.

This reverts commit 4169fb0.

Defer the complete runtime change from #535 until after the current release.
Preserve subsequent commits, including the React Native toolchain upgrades
and ExO parent variant attribution. A companion draft PR will restore this
change after the release has been published.
@bito-code-review

bito-code-review Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

@wiz-inc-38d59fb8d7

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 2 Medium 3 Low
Software Management Finding Software Management Findings -
Total 2 Medium 3 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@phobetron
Charles Hudson (phobetron) merged commit 28f12f5 into main Oct 16, 2026
46 checks passed
@phobetron
Charles Hudson (phobetron) deleted the revert/defer-runtime-preview-release branch October 16, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant