feat: remove Windows support and fix multiple builder bugs#10
Merged
Conversation
seuros
force-pushed
the
fix/remove-windows-and-bugs
branch
from
93193d6 to
0ebc68d
Compare
Member
|
Removing Windows is fine for me. I think Windows devs can just use Linux in Windows? I haven't really used Windows in decades. :/ |
Contributor
Author
|
Wsl works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed previously support of windows in ore. But this library still support windows.
Should we keep windows ?
NOTE: I did not test the implementation in windows previous, i just copied the flow from bundler and tested if it compile.
We can keep windows if you need it in other project , your call @pboling .