Update things under test/#43
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the test/ fixtures to run on Ruby 4.0 and updates the bundled dependencies (notably gRPC/protobuf and Sinatra/Rack) so the test containers continue to build and run with the newer runtime.
Changes:
- Bump Ruby to 4.0 for test containers and local test Ruby version (
test/.ruby-version, Dockerfiles). - Update gem dependency lockfiles under
test/(grpc/protobuf/rack/sinatra ecosystem, bundler 4 lock format with checksums). - Regenerate gRPC health protobuf Ruby stubs and adjust Sinatra apps for newer Rack/Sinatra defaults (host authorization setting).
Reviewed changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/grpc/lib/health_services_pb.rb |
Updated generated gRPC service stub; now references Watch RPC and new require path. |
test/grpc/lib/health_pb.rb |
Updated generated protobuf definitions to serialized descriptor format (protobuf v4 style). |
test/grpc/Gemfile.lock |
Bumped grpc/protobuf versions and updated lockfile format/checksums for bundler 4. |
test/grpc/Dockerfile |
Move gRPC test container to Ruby 4.0 base image. |
test/Gemfile.lock |
Update shared test gem lock (grpc/protobuf/rack) and bundler version/checksums. |
test/eds/Gemfile.lock |
Update EDS fixture dependencies to Sinatra 4 / Rack 3 ecosystem and bundler 4 lock format. |
test/eds/Gemfile |
Add rackup (and reorder) to support Sinatra/Rack 3 runtime. |
test/eds/eds.rb |
Configure Sinatra host authorization settings for the updated stack. |
test/eds/Dockerfile |
Move EDS test container to Ruby 4.0 base image. |
test/docker-compose.yml |
Remove deprecated version and remove unused expose stanza. |
test/app/Gemfile.lock |
Update app fixture dependencies to Sinatra 4 / Rack 3 ecosystem and bundler 4 lock format. |
test/app/Gemfile |
Add rackup dependency. |
test/app/Dockerfile |
Move app test container to Ruby 4.0 base image. |
test/app/app.rb |
Configure Sinatra host authorization settings for the updated stack. |
test/.ruby-version |
Bump test Ruby version to 4.0. |
Files not reviewed (2)
- test/grpc/lib/health_pb.rb: Language not supported
- test/grpc/lib/health_services_pb.rb: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eagletmt
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to Ruby 4.0 under test/, and while I'm at it, update various things under test/. Updating sinatra and google-protobuf required a bit of extra work (see commit logs)
@cookpad/platform-task-force please review 🙏