fix: mail and tel links not working#28
Open
uri-ustrell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tel:andmailto:links inside the WebView were silently dropped on Android. The WebView has no built-in handler for non-HTTP(S) schemes, so tapping a phone number or email address did nothing.Fix
Added
onShouldStartLoadWithRequestto the<WebView>inApp.js. Any URL starting withhttp://orhttps://loads normally inside the WebView. Any other scheme (tel:,mailto:, etc.) is delegated to the OS viaLinking.openURL(), which opens the default phone or email app.Changes
App.js: addedLinkingimport andonShouldStartLoadWithRequestprop to<WebView>This fix has not been validated against a real app session — no account was available to log in and reach a page containing
tel:ormailto:links. The implementation follows the standard pattern for this problem inreact-native-webviewand should be correct, but manual verification by someone with a staging/production account is strongly recommended before merging.(This is also the reason to be a quite inline and verbose code. I do recommend moving the logic outside the return.)
Closes #26