Week8a Timeline using React / React Bootstrap#14
Open
copelandhouse2 wants to merge 4 commits intogh-pagesfrom
Open
Week8a Timeline using React / React Bootstrap#14copelandhouse2 wants to merge 4 commits intogh-pagesfrom
copelandhouse2 wants to merge 4 commits intogh-pagesfrom
Conversation
…ntrol to go into edit mode. Still need to make edit value equal to card text
…te, it doesn't work. Need to fix
reneemeyer
reviewed
Sep 11, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Craig, nice job! Just a couple of things to clean up
| color: 'blue', | ||
| id: this.state.timeLine.length + 1 | ||
| }; | ||
| this.setState({timeLine: [...this.state.timeLine, card], inputValue: ''}) |
| this.setState({editCard: id,}); | ||
| }; | ||
|
|
||
| handleChange2=(e)=>{ |
There was a problem hiding this comment.
make this a more specific function name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeline designed in class