Open
Conversation
…ow cards in a list, add card, update card. This push contains sandbox code
…ard entry / update. Still a ways to go.
reneemeyer
approved these changes
Sep 25, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Craig, really nice job and separation of components. The only thing that I'm not the biggest fan of is the use of the window methods, but other than that really great job!
| <meta charset="utf-8"> | ||
| <title>My Trello App</title> | ||
|
|
||
| <script src="http://code.jquery.com/jquery-1.7.1.min.js"></script> |
There was a problem hiding this comment.
what are you using jquery for? you shouldn't have to use it if you're using react
| }; | ||
|
|
||
| if (this.state.activeCardID) { | ||
| window.Trello.put(`/cards/${this.state.activeCardID}`, {name: `Craig Card ${this.state.activeCardID}`}); |
There was a problem hiding this comment.
what is the reasoning behind accessing the DOM here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this checkpoint, I am using the Trello API to do the following