Open
Conversation
…rol for user to quite game or restart game.
…trol for user to quit or restart game
pieroapretto
reviewed
Aug 5, 2017
| @@ -116,19 +117,18 @@ function validEntry(myGuess) { | |||
| return myGuess.length === solution.length && myGuess.split('').every(myChar => letters.some(validLetter => myChar === validLetter)); | |||
| board[board.length] = `${guess} : ${generateHint(guess)}`; | ||
| if (guess === solution) { | ||
| board[board.length] = `${guess} : ${generateHint(guess)}`; | ||
| return true; // player won! |
There was a problem hiding this comment.
If you want to pass the tests your need to return "You guessed it!" on line 128 but I see you did something similar on line 146...
| myGuessArr[i] = ''; // clear out value. This sets us up to look for correct letter test. | ||
|
|
||
| // This piece of code tests for exact match | ||
| myGuessArr.forEach((letter, index) => { |
There was a problem hiding this comment.
Very clean syntax in a function that can get messy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for the following...