tests: add fips.hmac to verify VM will fail to reboot with FIPS and wrong hmac#4437
tests: add fips.hmac to verify VM will fail to reboot with FIPS and wrong hmac#4437jbtrystram merged 1 commit intocoreos:mainfrom
fips.hmac to verify VM will fail to reboot with FIPS and wrong hmac#4437Conversation
fips.hmac to verify VM will fail to reboot with FIPSfips.hmac to verify VM will fail to reboot with FIPS and wrong hmac
There was a problem hiding this comment.
Code Review
This pull request introduces a new test, fips.hmac, to ensure that a VM with FIPS enabled fails to reboot when its kernel HMAC is corrupted. The related changes to add a NoDracutFatalCheck flag are appropriate for this test case. The new test implementation is sound, but I've provided a couple of suggestions to improve its robustness and simplify the code.
600352e to
ff3c797
Compare
|
/cherrypick rhcos-4.19 |
|
@HuijingHei: new pull request created: #4471 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@HuijingHei: new pull request created: #4472 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@HuijingHei: new pull request created: #4473 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@HuijingHei: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick rhcos-4.15 |
|
@HuijingHei: #4437 failed to apply on top of branch "rhcos-4.13": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@HuijingHei: new pull request created: #4474 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@HuijingHei: new pull request created: #4475 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes: https://issues.redhat.com/browse/COS-3430