Skip to content

tests: add fips.hmac to verify VM will fail to reboot with FIPS and wrong hmac#4437

Merged
jbtrystram merged 1 commit intocoreos:mainfrom
HuijingHei:fips-hmac
Mar 5, 2026
Merged

tests: add fips.hmac to verify VM will fail to reboot with FIPS and wrong hmac#4437
jbtrystram merged 1 commit intocoreos:mainfrom
HuijingHei:fips-hmac

Conversation

@HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Feb 13, 2026

@HuijingHei HuijingHei changed the title tests: add fips.hmac to verify VM will fail to reboot with FIPS tests: add fips.hmac to verify VM will fail to reboot with FIPS and wrong hmac Feb 13, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test, fips.hmac, to ensure that a VM with FIPS enabled fails to reboot when its kernel HMAC is corrupted. The related changes to add a NoDracutFatalCheck flag are appropriate for this test case. The new test implementation is sound, but I've provided a couple of suggestions to improve its robustness and simplify the code.

jbtrystram
jbtrystram previously approved these changes Mar 4, 2026
Copy link
Member

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit

Copy link
Member

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jbtrystram jbtrystram merged commit c6612bc into coreos:main Mar 5, 2026
6 checks passed
@HuijingHei
Copy link
Member Author

/cherrypick rhcos-4.19
/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

@HuijingHei HuijingHei deleted the fips-hmac branch March 6, 2026 01:50
@openshift-cherrypick-robot

@HuijingHei: new pull request created: #4471

Details

In response to this:

/cherrypick rhcos-4.19
/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@HuijingHei: new pull request created: #4472

Details

In response to this:

/cherrypick rhcos-4.19
/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@HuijingHei: new pull request created: #4473

Details

In response to this:

/cherrypick rhcos-4.19
/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@HuijingHei: cannot checkout rhcos-4.19: error checking out "rhcos-4.19": exit status 1 error: pathspec 'rhcos-4.19' did not match any file(s) known to git

Details

In response to this:

/cherrypick rhcos-4.19
/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HuijingHei
Copy link
Member Author

/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13

@openshift-cherrypick-robot

@HuijingHei: #4437 failed to apply on top of branch "rhcos-4.13":

Applying: tests: add `fips.hmac` to verify VM will fail to reboot with FIPS and wrong hmac
Using index info to reconstruct a base tree...
M	mantle/kola/harness.go
M	mantle/kola/register/register.go
Falling back to patching base and 3-way merge...
Auto-merging mantle/kola/register/register.go
CONFLICT (content): Merge conflict in mantle/kola/register/register.go
Auto-merging mantle/kola/harness.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 tests: add `fips.hmac` to verify VM will fail to reboot with FIPS and wrong hmac

Details

In response to this:

/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@HuijingHei: new pull request created: #4474

Details

In response to this:

/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@HuijingHei: new pull request created: #4475

Details

In response to this:

/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants