cmd-koji-upload: new brew package name for base image builds#4569
cmd-koji-upload: new brew package name for base image builds#4569aaradhak wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the image naming convention in src/cmd-koji-upload to include -baseimage- for base images, and updates the corresponding documentation comments. The reviewer suggested expanding the NVR examples in the comments to show the resulting NVR format for both node and base images to prevent confusion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image) | ||
| # Version = 414.92.202307170903 | ||
| # Release = 0 | ||
| # NVR = rhcos-x86_64-414.92.202307170903-0 |
There was a problem hiding this comment.
The NVR example in the comment is incomplete. Since the comment was updated to include the base image name (rhcos-baseimage-x86_64), the NVR example should also be updated to show the resulting NVR for both the node image and the base image to avoid confusion.
| # Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image) | |
| # Version = 414.92.202307170903 | |
| # Release = 0 | |
| # NVR = rhcos-x86_64-414.92.202307170903-0 | |
| # Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image) | |
| # Version = 414.92.202307170903 | |
| # Release = 0 | |
| # NVR = rhcos-x86_64-414.92.202307170903-0 (node image) or rhcos-baseimage-x86_64-414.92.202307170903-0 (base image) |
| # Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image) | ||
| # Version = 414.92.202307170903 | ||
| # Release = 0 | ||
| # NVR = rhcos-x86_64-414.92.202307170903-0 |
There was a problem hiding this comment.
The NVR example in the comment is incomplete. Since the comment was updated to include the base image name (rhcos-baseimage-x86_64), the NVR example should also be updated to show the resulting NVR for both the node image and the base image to avoid confusion.
| # Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image) | |
| # Version = 414.92.202307170903 | |
| # Release = 0 | |
| # NVR = rhcos-x86_64-414.92.202307170903-0 | |
| # Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image) | |
| # Version = 414.92.202307170903 | |
| # Release = 0 | |
| # NVR = rhcos-x86_64-414.92.202307170903-0 (node image) or rhcos-baseimage-x86_64-414.92.202307170903-0 (base image) |
7b1af4c to
300d8ea
Compare
Base image and node image builds currently use the same Brew package
name (rhcos-{arch}) causing conflicts for ART when releasing the
node image. Use rhcos-baseimage-{arch} for base image builds to
match the new Brew packages created via
https://redhat.atlassian.net/browse/RELENG-253
The tags for rhocp-rhel versions 9.8, 10.1 and 10.2 are updated -
https://gitlab.cee.redhat.com/rcm/rcm-ansible/-/merge_requests/834
Fixes: https://redhat.atlassian.net/browse/COS-3989
|
Looks like CI is having an issue with the build. It doesnt seem to be related to this PR change. It seems to be happening with all the PRs opened recently. Looking into it. |
Base image and node image builds currently use the same Brew package name
(rhcos-{arch})causing conflicts for ART when releasing the node image. Use rhcos-baseimage-{arch} for base image builds to match the new Brew packages created via RELENG-253.The tags for rhocp-rhel versions 9.8, 10.1 and 10.2 are updated - https://gitlab.cee.redhat.com/rcm/rcm-ansible/-/merge_requests/834
Fixes: COS-3989