Skip to content

cmd-koji-upload: new brew package name for base image builds#4569

Open
aaradhak wants to merge 1 commit into
coreos:mainfrom
aaradhak:brewpkgar
Open

cmd-koji-upload: new brew package name for base image builds#4569
aaradhak wants to merge 1 commit into
coreos:mainfrom
aaradhak:brewpkgar

Conversation

@aaradhak

@aaradhak aaradhak commented Jun 3, 2026

Copy link
Copy Markdown
Member

Base image and node image builds currently use the same Brew package name (rhcos-{arch}) causing conflicts for ART when releasing the node image. Use rhcos-baseimage-{arch} for base image builds to match the new Brew packages created via RELENG-253.

The tags for rhocp-rhel versions 9.8, 10.1 and 10.2 are updated - https://gitlab.cee.redhat.com/rcm/rcm-ansible/-/merge_requests/834

Fixes: COS-3989

@aaradhak aaradhak requested a review from ravanelli June 3, 2026 21:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the image naming convention in src/cmd-koji-upload to include -baseimage- for base images, and updates the corresponding documentation comments. The reviewer suggested expanding the NVR examples in the comments to show the resulting NVR format for both node and base images to prevent confusion.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/cmd-koji-upload
Comment on lines +551 to 554
# Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image)
# Version = 414.92.202307170903
# Release = 0
# NVR = rhcos-x86_64-414.92.202307170903-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The NVR example in the comment is incomplete. Since the comment was updated to include the base image name (rhcos-baseimage-x86_64), the NVR example should also be updated to show the resulting NVR for both the node image and the base image to avoid confusion.

Suggested change
# Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image)
# Version = 414.92.202307170903
# Release = 0
# NVR = rhcos-x86_64-414.92.202307170903-0
# Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image)
# Version = 414.92.202307170903
# Release = 0
# NVR = rhcos-x86_64-414.92.202307170903-0 (node image) or rhcos-baseimage-x86_64-414.92.202307170903-0 (base image)

Comment thread src/cmd-koji-upload
Comment on lines +786 to 789
# Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image)
# Version = 414.92.202307170903
# Release = 0
# NVR = rhcos-x86_64-414.92.202307170903-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The NVR example in the comment is incomplete. Since the comment was updated to include the base image name (rhcos-baseimage-x86_64), the NVR example should also be updated to show the resulting NVR for both the node image and the base image to avoid confusion.

Suggested change
# Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image)
# Version = 414.92.202307170903
# Release = 0
# NVR = rhcos-x86_64-414.92.202307170903-0
# Name = rhcos-x86_64 (node image) or rhcos-baseimage-x86_64 (base image)
# Version = 414.92.202307170903
# Release = 0
# NVR = rhcos-x86_64-414.92.202307170903-0 (node image) or rhcos-baseimage-x86_64-414.92.202307170903-0 (base image)

@aaradhak aaradhak force-pushed the brewpkgar branch 2 times, most recently from 7b1af4c to 300d8ea Compare June 4, 2026 18:09
Base image and node image builds currently use the same Brew package
name (rhcos-{arch}) causing conflicts for ART when releasing the
node image. Use rhcos-baseimage-{arch} for base image builds to
match the new Brew packages created via
https://redhat.atlassian.net/browse/RELENG-253

The tags for rhocp-rhel versions 9.8, 10.1 and 10.2 are updated -
https://gitlab.cee.redhat.com/rcm/rcm-ansible/-/merge_requests/834

Fixes: https://redhat.atlassian.net/browse/COS-3989
@aaradhak aaradhak changed the title cmd-koji-upload: use separate brew package name for base image builds cmd-koji-upload: new brew package name for base image builds Jun 4, 2026

@travier travier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but looks OK

@ravanelli ravanelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaradhak

aaradhak commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Looks like CI is having an issue with the build. It doesnt seem to be related to this PR change. It seems to be happening with all the PRs opened recently. Looking into it.

12:21:57  ERROR: Error running start-build on at least one item: [buildconfig/coreos-ci-coreos-assembler-71893b5a-d622-4dae-92c1-e1a6a9f1d71d];
12:21:57  {err=Uploading archive file "dir.tar" as binary input for the build ...
12:21:57  
12:21:57  Uploading finished
12:21:57  Error from server (BadRequest): build coreos-ci-coreos-assembler-71893b5a-d622-4dae-92c1-e1a6a9f1d71d-1 failed: InvalidOutputReference: Output image could not be resolved.
12:21:57  , verb=start-build, cmd=oc --server=[https://172.30.0.1:443](https://172.30.0.1/) --certificate-authority="/var/run/secrets/kubernetes.io/serviceaccount/ca.crt" --namespace=fedora-coreos-pipeline --token=XXXXX start-build buildconfig/coreos-ci-coreos-assembler-71893b5a-d622-4dae-92c1-e1a6a9f1d71d --from-archive=dir.tar -o=name , out=, status=1}
12:21:57  
12:21:57  
12:21:57  GitHub has been notified of this commit’s build result
12:21:57  
12:21:57  Finished: FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants