Skip to content

deps: drop python3-pyrsistent#4571

Merged
jbtrystram merged 1 commit into
coreos:mainfrom
jbtrystram:drop-pyrsistent-dep
Jun 4, 2026
Merged

deps: drop python3-pyrsistent#4571
jbtrystram merged 1 commit into
coreos:mainfrom
jbtrystram:drop-pyrsistent-dep

Conversation

@jbtrystram

Copy link
Copy Markdown
Member

This one have been included with the initial osbuild work but appears to no longer be used by osbuild and is orphaned in F44, so let's drop it.

See #4541

This one have been included with the initial osbuild work but appears
to no longer be used by osbuild and is orphaned in F44, so let's drop
it.

See coreos#4541
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jbtrystram jbtrystram marked this pull request as ready for review June 4, 2026 06:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the python3-pyrsistent package from rpms.in.yaml and src/vmdeps.txt. Feedback indicates that the lockfile rpms.lock.yaml must also be updated to keep it in sync, which can be done by running the ci/hermetic/update_rpms_lockfile script.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread rpms.in.yaml
- python3-koji
- python3-koji-cli-plugins
- python3-libvirt
- python3-pyrsistent

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When removing a package from rpms.in.yaml, the lockfile rpms.lock.yaml should also be updated to keep them in sync. Please run the ci/hermetic/update_rpms_lockfile script to regenerate the lockfile.

@jbtrystram

Copy link
Copy Markdown
Member Author

@joelcapitao joelcapitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbtrystram jbtrystram merged commit 3411a13 into coreos:main Jun 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants