ore: drop Alibaba Cloud SDK and aliyun upload code paths#4572
ore: drop Alibaba Cloud SDK and aliyun upload code paths#4572jbtrystram wants to merge 1 commit into
Conversation
The alibaba-cloud-sdk-go and aliyun-oss-go-sdk dependencies are no longer used for uploading images. Remove all ore aliyun subcommands, the platform API wrapper, auth config reader, Python upload/replicate wrappers, and the vendored SDKs (plus their transitive deps). Image building (qcow2 artifact via osbuild) is preserved. The v1.json schema and cosa_v1.go types for upload metadata are kept for backward compatibility with existing build metadata. This was prompted by orphaning of the aliyun sdk package in F44. Also, this SDK is no longer maintained upstream. Authored-by: Opencode.ai claude-opus-4-6@default
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Code Review
This pull request removes all support for the Aliyun (Alibaba Cloud) platform across the codebase, including its API client, CLI commands, Go dependencies, and documentation. Feedback on the changes suggests using a list literal instead of a single-element tuple in src/cmd-generate-release-meta to improve readability and follow Python idioms.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # AWS specific additions | ||
| for meta_key, cloud, image_field in ("amis", "aws", "hvm"),: |
There was a problem hiding this comment.
Using a trailing comma to define a single-element tuple (e.g., ("amis", "aws", "hvm"),) can be hard to read and easily mistaken for a typo. Using a list literal [("amis", "aws", "hvm")] is much more idiomatic and clearer.
| # AWS specific additions | |
| for meta_key, cloud, image_field in ("amis", "aws", "hvm"),: | |
| # AWS specific additions | |
| for meta_key, cloud, image_field in [("amis", "aws", "hvm")]: |
The alibaba-cloud-sdk-go and aliyun-oss-go-sdk dependencies are no longer used for uploading images. Remove all ore aliyun subcommands, the platform API wrapper, auth config reader, Python upload/replicate wrappers, and the vendored SDKs (plus their transitive deps).
Image building (qcow2 artifact via osbuild) is preserved. The v1.json schema and cosa_v1.go types for upload metadata are kept for backward compatibility with existing build metadata.
This was prompted by orphaning of the aliyun sdk package in F44. Also, this SDK is no longer maintained upstream.
Authored-by: Opencode.ai claude-opus-4-6@default