Skip to content

ore: drop Alibaba Cloud SDK and aliyun upload code paths#4572

Draft
jbtrystram wants to merge 1 commit into
coreos:mainfrom
jbtrystram:aliyun_sdk_drop
Draft

ore: drop Alibaba Cloud SDK and aliyun upload code paths#4572
jbtrystram wants to merge 1 commit into
coreos:mainfrom
jbtrystram:aliyun_sdk_drop

Conversation

@jbtrystram

Copy link
Copy Markdown
Member

The alibaba-cloud-sdk-go and aliyun-oss-go-sdk dependencies are no longer used for uploading images. Remove all ore aliyun subcommands, the platform API wrapper, auth config reader, Python upload/replicate wrappers, and the vendored SDKs (plus their transitive deps).

Image building (qcow2 artifact via osbuild) is preserved. The v1.json schema and cosa_v1.go types for upload metadata are kept for backward compatibility with existing build metadata.

This was prompted by orphaning of the aliyun sdk package in F44. Also, this SDK is no longer maintained upstream.

Authored-by: Opencode.ai claude-opus-4-6@default

The alibaba-cloud-sdk-go and aliyun-oss-go-sdk dependencies are no
longer used for uploading images. Remove all ore aliyun subcommands,
the platform API wrapper, auth config reader, Python upload/replicate
wrappers, and the vendored SDKs (plus their transitive deps).

Image building (qcow2 artifact via osbuild) is preserved. The v1.json
schema and cosa_v1.go types for upload metadata are kept for backward
compatibility with existing build metadata.

This was prompted by orphaning of the aliyun sdk package in F44. Also,
this SDK is no longer maintained upstream.

Authored-by: Opencode.ai claude-opus-4-6@default
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes all support for the Aliyun (Alibaba Cloud) platform across the codebase, including its API client, CLI commands, Go dependencies, and documentation. Feedback on the changes suggests using a list literal instead of a single-element tuple in src/cmd-generate-release-meta to improve readability and follow Python idioms.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +175 to +176
# AWS specific additions
for meta_key, cloud, image_field in ("amis", "aws", "hvm"),:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a trailing comma to define a single-element tuple (e.g., ("amis", "aws", "hvm"),) can be hard to read and easily mistaken for a typo. Using a list literal [("amis", "aws", "hvm")] is much more idiomatic and clearer.

Suggested change
# AWS specific additions
for meta_key, cloud, image_field in ("amis", "aws", "hvm"),:
# AWS specific additions
for meta_key, cloud, image_field in [("amis", "aws", "hvm")]:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant