fix(createImageSliceSynchronizer): fix imageSliceSync not getting VOLUME_NEW_IMAGE event #2514
+694
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#2472
createImageSliceSynchronizer uses string instead of ENUM and was missing source to listen for correct event.
Also getClosestImageId check regressed in #2485
Changes & Results
Testing
Tests for synchronization added. (Stack to Stack, Volume to Stack, Volume to Volume, bidirectional)
I am not 100% sure about Volume to Stack and Stack to Volume expected positions.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment