Merged
Conversation
* Use core opengl version so works on OSX * Use texture, not deprecated texture2D (and renamed appropriately)
* GCC 12 wasn't compiling for me anymore. I had to update to 13- unsure if this is MacOSX specific, but updating * We use SDL3 now, not SDL2. * SDL2_Image is gone * Upped meson version to 1.6 SDL3 seems to require it, and tracy at least requires 1.3. In any case I had to update past 1.0.0 (which I had) to build. * Updated version number in meson to be representative of the actual project now (not pre 4.1!)
Contributor
Author
|
Hmm. Looks like we only need SDL3 as a dependency on Mac? if host_machine.system() == 'darwin' I see we're linking statically on Linux/Windows- should I remove SDL3 as a dependency in README instructions for Linux? |
…ng set before tracy had a change to do its thing ../external/sources/tracy/meson.build:230:6: ERROR: Tried to override dependency 'tracy' which has already been resolved or overridden at ../external/sources/allegro 4.4.3.1-custom/meson.build:75
HeliumAnt
reviewed
Jan 1, 2026
Contributor
HeliumAnt
left a comment
There was a problem hiding this comment.
readme is quite out of date indeed
(until we use systemlib sdl3 again)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bunch of things I noticed while trying to build and run the game on Mac. Some of this is a bit guessworky as I'm not too experienced in this side of things. See the commit descriptions for my justifications for the various changes, but I've probably gotten some stuff wrong here or missed other stuff so would be great to have a careful look over.