Open
Conversation
jongeorge1
reviewed
Mar 30, 2026
Contributor
|
We should update the README with details about the new modules |
jongeorge1
reviewed
Mar 31, 2026
| expected, | ||
| actual, | ||
| check_row_order=check_row_order, | ||
| check_column_order=not check_like, |
Contributor
There was a problem hiding this comment.
We've got a few tests across repos where we use this that only specify a subset of columns from the actual dataframe to check.
The previous iteration of this method supported that, the updated one doesn't. I think it's good that we're explicit as to whether we're expecting the full list of columns to match or not, so we should have either another parameter or a separate method to support this use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.