fix(ui): drawer bar overlapping close button - #850
Open
NathanBrodin wants to merge 1 commit into
Open
Conversation
Render DrawerBar before close button so close stays clickable, and make bar pointer-events-none since it is decorative (aria-hidden).
|
@NathanBrodin is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, when
showBarandshowCloseButtonare both enabled, the bar renders on top of the close button and blocks clicks.before.mp4
I swaped the order so the close button renders last, and added
pointer-events-nonetoDrawerBarsince it's decorative (aria-hidden).after.mp4
I hope this HUGE PR will not be an issue! Love your work!