Skip to content

[feat][evaluation] prompt evaltarget support traj#458

Open
lsy357 wants to merge 6 commits intomainfrom
fix/retryitems
Open

[feat][evaluation] prompt evaltarget support traj#458
lsy357 wants to merge 6 commits intomainfrom
fix/retryitems

Conversation

@lsy357
Copy link
Collaborator

@lsy357 lsy357 commented Mar 16, 2026

What type of PR is this?

feat

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@lsy357 lsy357 changed the title [fix][evaluation] prompt evaltarget support traj [feat][evaluation] prompt evaltarget support traj Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ation/domain/service/expt_manage_execution_impl.go 33.33% 4 Missing ⚠️
...on/domain/service/target_source_loopprompt_impl.go 63.63% 3 Missing and 1 partial ⚠️
...ion/domain/service/expt_run_scheduler_mode_impl.go 60.00% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (56.52%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   74.36%   74.35%   -0.01%     
==========================================
  Files         629      629              
  Lines       65995    66012      +17     
==========================================
+ Hits        49078    49085       +7     
- Misses      13633    13646      +13     
+ Partials     3284     3281       -3     
Flag Coverage Δ
unittests 74.35% <56.52%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/evaluation/domain/entity/target.go 93.93% <100.00%> (ø)
...ion/domain/service/expt_run_scheduler_mode_impl.go 84.54% <60.00%> (-0.16%) ⬇️
...ation/domain/service/expt_manage_execution_impl.go 68.97% <33.33%> (-1.14%) ⬇️
...on/domain/service/target_source_loopprompt_impl.go 89.48% <63.63%> (-0.76%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74954fc...862f1c7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant