fix: set errno consistently in tied handle methods#395
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
Three errno bugs in FileHandle.pm: 1. SEEK: missing $! = EINVAL when seeking to a negative position (closes cpan-authors#342). Real Perl's seek/sysseek sets EINVAL on failure. 2. GETC: missing $! = EBADF when called on a write-only handle. READ and WRITE already set EBADF correctly; GETC was missed. 3. READLINE: missing $! = EBADF when called on a write-only handle. Same inconsistency as GETC — the warning was emitted but errno was not set. Tests updated to verify errno is set in all three cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix three missing errno assignments in
FileHandle.pmtied methods — SEEK, GETC, and READLINE now correctly set$!on error, matching the behavior of READ, WRITE, PRINT, and PRINTF.Why
Some tied methods (READ, WRITE, PRINT) already set
$!on permission/error paths, but SEEK, GETC, and READLINE were missed. Code under test that checks$!after a failed seek/getc/readline would see stale errno values from mocked handles, potentially masking bugs.Closes #342.
How
$! = EINVALbefore returning 0 on negative position (1 line)$! = EBADFwhen called on write-only handle (1 line)$! = EBADFwhen called on write-only handle (1 line)All three follow the existing pattern used by READ/WRITE/PRINT in the same file.
Testing
t/seek.t: verify EINVAL on negative seeks (SEEK_SET, SEEK_CUR, SEEK_END) + failed builtinseek()preserves tell positiont/readline.t: verify EBADF on write-onlyreadline()(scalar + list context) andgetc()🤖 Generated with Claude Code
Quality Report
Changes: 3 files changed, 21 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline