fix: preserve errno across CORE::GLOBAL success paths#397
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
Internal helpers _abs_path_to_file() and __cwd_abs_path() call getcwd() and getpwent() which can clobber $! as a side effect. Add local $! guards so callers see their own errno, not internal noise. Fixes cpan-authors#396. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Protect
$!(errno) from being clobbered by internal helper calls on successful CORE::GLOBAL override paths.Why
Issue #396:
_abs_path_to_file()callsgetcwd()(relative paths) andgetpwent()/endpwent()(tilde paths), which can set$!as a side effect. Since no override saved/restored errno, callers saw dirty$!after successful operations — violating POSIX semantics where builtins don't modify errno on success.How
local $!at the top of_abs_path_to_file()— protects all 16 call sites at oncelocal $!aroundCwd::getcwd()in__cwd_abs_path()— surgical guard that doesn't mask the intentional$! = ELOOPset later in that functionTwo lines of protection, zero behavioral change on failure paths.
Testing
New
t/errno_preservation.t— verifies$!survives open, stat, unlink, and Cwd::abs_path on mocked files. Full test suite passes.Closes #396
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 91 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline