Repository navigation
Conversation
tkoeppe
commented
Oct 24, 2026
Contributor
Fixes ISO/CS 046 (C++26 DIS)
eisenwave
reviewed
Oct 25, 2026
Comment on lines
+557
to
+570
| \begin{itemize} | ||
| \item header names; | ||
| \item placeholder tokens produced by preprocessing \tcode{import} | ||
| and \tcode{module} directives | ||
| (\grammarterm{import-keyword}, \grammarterm{module-keyword}, | ||
| and \grammarterm{export-keyword}); | ||
| \item identifiers; | ||
| \item preprocessing numbers; | ||
| \item character literals (including user-defined character literals); | ||
| \item string literals (including user-defined string literals); | ||
| \item preprocessing operators and punctuators; | ||
| \item single non-whitespace characters that do not lexically | ||
| match the other preprocessing token categories. | ||
| \end{itemize} |
Member
There was a problem hiding this comment.
I feel like this would be cleaner if you used the \item-on-separate-line form here:
Suggested change
| \begin{itemize} | |
| \item header names; | |
| \item placeholder tokens produced by preprocessing \tcode{import} | |
| and \tcode{module} directives | |
| (\grammarterm{import-keyword}, \grammarterm{module-keyword}, | |
| and \grammarterm{export-keyword}); | |
| \item identifiers; | |
| \item preprocessing numbers; | |
| \item character literals (including user-defined character literals); | |
| \item string literals (including user-defined string literals); | |
| \item preprocessing operators and punctuators; | |
| \item single non-whitespace characters that do not lexically | |
| match the other preprocessing token categories. | |
| \end{itemize} | |
| \begin{itemize} | |
| \item | |
| header names; | |
| \item | |
| placeholder tokens produced by preprocessing \tcode{import} and \tcode{module} directives | |
| (\grammarterm{import-keyword}, \grammarterm{module-keyword}, and \grammarterm{export-keyword}); | |
| \item | |
| identifiers; | |
| \item | |
| preprocessing numbers; | |
| \item | |
| character literals | |
| (including user-defined character literals); | |
| \item | |
| string literals | |
| (including user-defined string literals); | |
| \item | |
| preprocessing operators and punctuators; | |
| \item | |
| single non-whitespace characters | |
| that do not lexically match the other preprocessing token categories. | |
| \end{itemize} |
It's just more maintainable that way and the semantic line breaks come out cleaner. Perhaps we could also add some forward references here. We mention "string literals" which are described in subsequent subclause [lex.string], but don't provide a forward reference. That would make each item longer as well and justify having multiple lines for more \items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.