Skip to content

refactor: drive visit() switches from existing X-macro .inc files#1194

Open
gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota:refactor/drive_visit_switches_from_existing_xmacro_inc_files
Open

refactor: drive visit() switches from existing X-macro .inc files#1194
gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota:refactor/drive_visit_switches_from_existing_xmacro_inc_files

Conversation

@gennaroprota
Copy link
Copy Markdown
Collaborator

The hand-coded visit() switches in Type.hpp, TArg.hpp, and TParam.hpp were duplicating the type list already enumerated by their respective *Nodes.inc X-macro files. This rewrites each to consume the .inc file, instead, matching the pattern Symbol.hpp, Name.hpp, Block.hpp, Inline.hpp already use, so the .inc is the single source of truth.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

🚧 Danger.js checks for MrDocs are experimental; expect some rough edges while we tune the rules.

⚠️ Warnings

Warning

Add a brief note about how this change was tested (or why tests are not needed).

🧾 Changes by Scope

Scope Lines Δ% Lines Δ Lines + Lines - Files Δ Files + Files ~ Files ↔ Files -
🛠️ Source 100% 80 19 61 3 - 3 - -
Total 100% 80 19 61 3 - 3 - -

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

  • include/mrdocs/Metadata/Type.hpp (Source): 44 lines Δ (+7 / -37)
  • include/mrdocs/Metadata/TArg.hpp (Source): 18 lines Δ (+6 / -12)
  • include/mrdocs/Metadata/TParam.hpp (Source): 18 lines Δ (+6 / -12)

Generated by 🚫 dangerJS against 5b2c18c

@gennaroprota gennaroprota force-pushed the refactor/drive_visit_switches_from_existing_xmacro_inc_files branch from 6bc06db to a0dcd2b Compare May 1, 2026 10:47
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.18%. Comparing base (966e652) to head (5b2c18c).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
include/mrdocs/Metadata/TArg.hpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1194      +/-   ##
===========================================
- Coverage    79.20%   79.18%   -0.02%     
===========================================
  Files          308      308              
  Lines        32332    32287      -45     
  Branches      6493     6484       -9     
===========================================
- Hits         25607    25565      -42     
+ Misses        4355     4352       -3     
  Partials      2370     2370              
Flag Coverage Δ
bootstrap 81.89% <ø> (ø)
cpp 78.90% <93.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cppalliance-bot
Copy link
Copy Markdown

cppalliance-bot commented May 1, 2026

An automated preview of the documentation is available at https://1194.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-05-01 16:09:02 UTC

The hand-coded `visit()` switches in Type.hpp, TArg.hpp, and TParam.hpp
were duplicating the type list already enumerated by their respective
*Nodes.inc X-macro files. This rewrites each to consume the .inc file,
instead, matching the pattern Symbol.hpp, Name.hpp, Block.hpp,
Inline.hpp already use, so the .inc is the single source of truth.
@gennaroprota gennaroprota force-pushed the refactor/drive_visit_switches_from_existing_xmacro_inc_files branch from a0dcd2b to 5b2c18c Compare May 1, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants