fighting for my life out here - #33
Merged
Merged
Conversation
Local builds were pinned to an older Rust while CI linted and tested on stable, and that skew just produced three CI failures on a pull request that had passed every local check. This change puts local builds and CI on the same stable toolchain, removes the minimum-version declarations and the CI job that enforced them, and deletes the runner validation script together with its dedicated test. The three failures the skew exposed are fixed in place: an unnecessary-parentheses lint, a pair of lint expectations consolidated under a new name, and a paused-clock test structurally incompatible with its real-time rendezvous. - `rust-toolchain.toml` now selects `channel = "stable"`, so local builds track the same toolchain CI uses; the header comment describes that rule instead of the removed pin. - `rust-version` leaves the workspace manifest and the crate manifests, ending the resolver's preference for dependency versions compatible with the old minimum. - `crates/gateway-stt/src/audio.rs` drops the parentheses around the trait object type in an error-chain assertion, clearing the lint stable fires on them. - `crates/workshop/src/bridge.rs` expects `clippy::ref_as_ptr` on the test module in place of `clippy::ptr_as_ptr` and `clippy::borrow_as_ptr`, which stable consolidated into the single lint. - `decode_rendezvous_timeout_releases_a_late_arrival_and_permits_a_follow_up` runs on the real clock again, because a paused clock cannot drive the test's real-time condvar rendezvous. - `.github/workflows/ci.yml` loses the `msrv` job and every `RUSTUP_TOOLCHAIN` override, and `ci-green` no longer lists `msrv` among its needs. - `tools/validate-rust-1.89.0.ps1` is deleted along with `tools/check-stt-native-workflow.test.mjs`, the test file that existed only to exercise it. - `README.md` loses the minimum-version section, the version badge, and the version number in the build instructions; `AGENTS.md` loses the bullet warning that CI lints on a newer toolchain than local. Design: removes feature-flag @ .github/workflows/ci.yml Plan: vibe/2026-09-11-2-unify-toolchain.md
State the timeout durations in the units the values use. The change rewrites four timeout constants in `artifacts.rs`, `live.rs`, `backoff.rs`, and `cuda.rs` from `Duration::from_secs` products to `Duration::from_mins` and `Duration::from_hours`. - The rewritten constants keep their previous values; no test or call site changes.
Plan: vibe/2026-09-11-2-unify-toolchain.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.