Skip to content

More CI fixes#200

Merged
mborland merged 7 commits intodevelopfrom
ci
May 5, 2026
Merged

More CI fixes#200
mborland merged 7 commits intodevelopfrom
ci

Conversation

@mborland
Copy link
Copy Markdown
Member

@mborland mborland commented May 5, 2026

No description provided.

@mborland mborland added this to the v0.1.0 milestone May 5, 2026
@mborland mborland self-assigned this May 5, 2026
@mborland mborland added the Quality Improve testing or CI environment label May 5, 2026
@mborland
Copy link
Copy Markdown
Member Author

mborland commented May 5, 2026

@Flamefire sorry to bother you again, but how do I exclude MINGW32? I matched what you have here: https://github.com/boostorg/boost-ci/blob/37bb0ac4943a808b2fab812855bb09b70dec7fb8/.github/workflows/ci_test_opposite.yml#L47, but it still seems to run.

@Flamefire
Copy link
Copy Markdown
Contributor

Yeah, I made a mistake there and fixed it now.
The correct option is enable_mingw: false

You can see all options including description in the file directly: https://github.com/boostorg/boost-ci/blob/master/.github/workflows/reusable.yml

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.3%. Comparing base (8525e5f) to head (53e06d8).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #200      +/-   ##
==========================================
+ Coverage     65.6%   97.3%   +31.8%     
==========================================
  Files          178     178              
  Lines        13778   14004     +226     
  Branches      5229    5229              
==========================================
+ Hits          9029   13622    +4593     
- Misses         306     313       +7     
+ Partials      4443      69    -4374     
Files with missing lines Coverage Δ
include/boost/safe_numbers/detail/float_basis.hpp 79.1% <100.0%> (+12.3%) ⬆️

... and 150 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8525e5f...53e06d8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 4fb815c into develop May 5, 2026
47 checks passed
@mborland mborland deleted the ci branch May 5, 2026 21:33
@Flamefire
Copy link
Copy Markdown
Contributor

FYI: I also updated the Boost.CI jobs that use the windows-2025 image with VS 2022 and CMake that failed before (see the previous PR: "missing Visual Studio" errors)

That's now using VS 2026 explicitly so your jobs here are now green, confirming this worked :)

@mborland
Copy link
Copy Markdown
Member Author

mborland commented May 6, 2026

FYI: I also updated the Boost.CI jobs that use the windows-2025 image with VS 2022 and CMake that failed before (see the previous PR: "missing Visual Studio" errors)

That's now using VS 2026 explicitly so your jobs here are now green, confirming this worked :)

Yes, everything looks good now, thanks again. Of note, I did have to make one more change to cmake_test to get everything green on windows: https://github.com/cppalliance/safe_numbers/blob/develop/test/cmake_test/CMakeLists.txt#L78. The normal add_test(quick quick) failed the subdir test on Windows ON Debug, but not Windows OFF Debug: https://github.com/cppalliance/safe_numbers/actions/runs/25400073608/job/74496964056#step:11:94

@Flamefire
Copy link
Copy Markdown
Contributor

I see the working config uses
quick.vcxproj -> D:\a\safe_numbers\boost-root\libs\safe_numbers\test\cmake_test\__build_cmake_subdir_test__\Debug\quick.exe
The failing one
quick.vcxproj -> D:\d\a\safe_numbers\boost-root\libs\safe_numbers\test\cmake_test\__build_cmake_subdir_test__\bin\Debug\quick.exe

And in only looks in Debug/quick.exe, if at all

For the shared case all executables and libraries will be put in a single folder on Windows because RPATH does not exist. So I added -DCMAKE_RUNTIME_OUTPUT_DIRECTORY='$(pwd)/bin' there.

The NAME COMMAND signature is preferable in any case, see https://cmake.org/cmake/help/v3.10/command/add_test.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Quality Improve testing or CI environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants