vf_settokenvalue.cpp: actually use the known value in setTokenValue()

Author: firewave

lib/token.cpp

@@ -2545,6 +2545,18 @@ bool Token::hasKnownSymbolicValue(const Token* tok) const
     });
 }
 
+const ValueFlow::Value* Token::getKnownValue() const
+{
+    if (!mImpl->mValues)
+        return nullptr;
+    if (mImpl->mValues->empty())
+        return nullptr;
+    auto it = std::find_if(mImpl->mValues->begin(), mImpl->mValues->end(), [&](const ValueFlow::Value& value) {
+        return value.isKnown();
+    });
+    return it == mImpl->mValues->end() ? nullptr : &*it;
+}
+
 const ValueFlow::Value* Token::getKnownValue(ValueFlow::Value::ValueType t) const
 {
     if (!mImpl->mValues)

lib/token.h

@@ -1321,6 +1321,7 @@ class CPPCHECKLIB Token {
     bool hasKnownValue(ValueFlow::Value::ValueType t) const;
     bool hasKnownSymbolicValue(const Token* tok) const;
 
+    const ValueFlow::Value* getKnownValue() const;
     const ValueFlow::Value* getKnownValue(ValueFlow::Value::ValueType t) const;
     MathLib::bigint getKnownIntValue() const {
         assert(!mImpl->mValues->empty());

lib/vf_settokenvalue.cpp

@@ -391,12 +391,10 @@ namespace ValueFlow
 
         else if (parent->str() == "?" && tok->str() == ":" && tok == parent->astOperand2() && parent->astOperand1()) {
             // is condition always true/false?
-            if (parent->astOperand1()->hasKnownValue()) {
-                const Value &condvalue = parent->astOperand1()->values().front();
-                assert(condvalue.isKnown());
-                const bool cond(condvalue.isTokValue() || (condvalue.isIntValue() && condvalue.intvalue != 0));
+            if (const Value* condvalue = parent->astOperand1()->getKnownValue()) {
+                const bool cond(condvalue->isTokValue() || (condvalue->isIntValue() && condvalue->intvalue != 0));
                 if (cond && !tok->astOperand1()) { // true condition, no second operator
-                    setTokenValue(parent, condvalue, settings);
+                    setTokenValue(parent, *condvalue, settings);
                 } else {
                     const Token *op = cond ? tok->astOperand1() : tok->astOperand2();
                     if (!op) // #7769 segmentation fault at setTokenValue()