valueflow.cpp: avoid unnecessary copies in valueFlowInferCondition()

firewave · firewave · commit be58ea779973 · 2026-02-13T09:51:29.000+01:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5070,8 +5070,7 @@ static void valueFlowInferCondition(TokenList& tokenlist, const Settings& settin
             std::vector<ValueFlow::Value> result = infer(makeIntegralInferModel(), "!=", tok->values(), 0);
             if (result.size() != 1)
                 continue;
-            ValueFlow::Value value = result.front();
-            setTokenValue(tok, std::move(value), settings);
+            setTokenValue(tok, std::move(result.front()), settings);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -5070,8 +5070,7 @@ static void valueFlowInferCondition(TokenList& tokenlist, const Settings& settin`
`5070`	`5070`	`std::vector<ValueFlow::Value> result = infer(makeIntegralInferModel(), "!=", tok->values(), 0);`
`5071`	`5071`	`if (result.size() != 1)`
`5072`	`5072`	`continue;`
`5073`		`- ValueFlow::Value value = result.front();`
`5074`		`- setTokenValue(tok, std::move(value), settings);`
	`5073`	`+ setTokenValue(tok, std::move(result.front()), settings);`
`5075`	`5074`	`}`
`5076`	`5075`	`}`
`5077`	`5076`	`}`