Skip to content

Fix #14006 (CI: upload cppcheck premium sarif results to github)#7662

Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom
cppchecksolutions:fix-14006
Jul 15, 2025
Merged

Fix #14006 (CI: upload cppcheck premium sarif results to github)#7662
danmar merged 1 commit intocppcheck-opensource:mainfrom
cppchecksolutions:fix-14006

Conversation

@danmar
Copy link
Copy Markdown
Collaborator

@danmar danmar commented Jul 11, 2025

No description provided.

@danmar danmar changed the title test1 Fix #14006 (CI: use cppcheck sarif output in github) Jul 11, 2025
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@danmar danmar changed the title Fix #14006 (CI: use cppcheck sarif output in github) test latest cppcheckpremium Jul 14, 2025
@danmar danmar force-pushed the fix-14006 branch 2 times, most recently from ca4787a to b4dbe48 Compare July 14, 2025 16:22
@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Jul 14, 2025

@Nettozx I would like your feedback about removing the "security-value". Will it still be compatible with your tooling?

github write some strange error message when we have it..

@Nettozx
Copy link
Copy Markdown
Contributor

Nettozx commented Jul 14, 2025

@Nettozx I would like your feedback about removing the "security-value". Will it still be compatible with your tooling?

github write some strange error message when we have it..

Can you show me the error message it was showing? I haven't had issues uploading cppcheck sarif files with the changes in my fork

@Nettozx
Copy link
Copy Markdown
Contributor

Nettozx commented Jul 14, 2025

Oh I see. I resolved this in my fork, its due to it passing the severity as a number instead of a string.

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Jul 14, 2025

@Nettozx the security-value problem is shown now. From the log:

Error: Code Scanning could not process the submitted SARIF file:
parsing restricted subset of SARIF data has failed: parse error: expected string near offset 115277 of '9.9'

The sarif results can be downloaded if you want to look closer on it.

If you have a better suggestion let me know..

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Jul 14, 2025

Oh I see. I resolved this in my fork, its due to it passing the severity as a number instead of a string.

ah ok.. I will try that!

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Jul 14, 2025

@Nettozx thanks, as far as I see this works now.. let's see what happens if I turn on all CI..

@sonarqubecloud
Copy link
Copy Markdown

@danmar danmar changed the title test latest cppcheckpremium Fix #14006 (CI: upload cppcheck premium sarif results to github) Jul 15, 2025
@danmar danmar marked this pull request as ready for review July 15, 2025 06:51
@danmar danmar merged commit 515c73e into cppcheck-opensource:main Jul 15, 2025
63 checks passed
@danmar danmar deleted the fix-14006 branch July 15, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants