Skip to content

Fix #1420 (GUI: Clarify results view context menu) #7674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glankk merged 2 commits into from
Jul 15, 2025
Merged

Fix #1420 (GUI: Clarify results view context menu) #7674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7044b94
Context menu improvements
glankk Jul 15, 2025
6d26785
Fix clang-tidy issue
glankk Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions gui/resultstree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,21 +747,35 @@ void ResultsTree::contextMenuEvent(QContextMenuEvent * e)
menu.addSeparator();
}

int selectedFiles = 0;
int selectedResults = 0;

for (auto row : mSelectionModel->selectedRows()) {
auto *item = mModel.itemFromIndex(row);
if (!item->parent())
selectedFiles++;
else if (!item->parent()->parent())
selectedResults++;
}

//Create an action for the application
auto *recheckAction = new QAction(tr("Recheck"), &menu);
auto *recheckAction = new QAction(tr("Recheck %1 file(s)").arg(selectedFiles), &menu);
auto *copyAction = new QAction(tr("Copy"), &menu);
auto *hide = new QAction(tr("Hide"), &menu);
auto *hide = new QAction(tr("Hide %1 result(s)").arg(selectedResults), &menu);
auto *hideallid = new QAction(tr("Hide all with id"), &menu);
auto *opencontainingfolder = new QAction(tr("Open containing folder"), &menu);

if (multipleSelection) {
if (selectedFiles == 0 || mThread->isChecking())
recheckAction->setDisabled(true);

if (selectedResults == 0)
hide->setDisabled(true);

if (selectedResults == 0 || multipleSelection)
hideallid->setDisabled(true);

if (multipleSelection)
opencontainingfolder->setDisabled(true);
}
if (mThread->isChecking())
recheckAction->setDisabled(true);
else
recheckAction->setDisabled(false);

menu.addAction(recheckAction);
menu.addSeparator();
Expand All @@ -774,7 +788,9 @@ void ResultsTree::contextMenuEvent(QContextMenuEvent * e)
{
QVariantMap itemdata = mContextItem->data().toMap();
const QString messageId = itemdata[ERRORID].toString();
suppress->setEnabled(!ErrorLogger::isCriticalErrorId(messageId.toStdString()));

if (selectedResults == 0 || ErrorLogger::isCriticalErrorId(messageId.toStdString()))
suppress->setDisabled(true);
}
menu.addAction(suppress);
connect(suppress, &QAction::triggered, this, &ResultsTree::suppressSelectedIds);
Expand Down