Skip to content

Fix #14023 FP functionStatic (inconclusive) for const overload #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Jul 21, 2025
Merged

Fix #14023 FP functionStatic (inconclusive) for const overload #7679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f29685
Fix #14023 FP functionStatic (inconclusive) for const overload
web-flow Jul 17, 2025
1a7113b
Merge branch 'main' into chr_14023
chrchr-github Jul 17, 2025
01e5280
Format
web-flow Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2189,6 +2189,13 @@ void CheckClass::checkConst()
const bool suggestStatic = memberAccessed != MemberAccess::MEMBER && !func.isOperator();
if ((returnsPtrOrRef || func.isConst() || func.hasLvalRefQualifier()) && !suggestStatic)
continue;
if (suggestStatic && func.isConst()) {
const auto overloads = func.getOverloadedFunctions();
if (overloads.size() > 1 && std::any_of(overloads.begin(), overloads.end(), [&](const Function* ovl) {
return &func != ovl && func.argCount() == ovl->argCount() && func.argsMatch(ovl->functionScope, ovl->argDef, func.argDef, emptyString, 0);
}))
continue;
}

std::string classname = scope->className;
const Scope *nest = scope->nestedIn;
Expand Down
10 changes: 10 additions & 0 deletions test/testclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ class TestClass : public TestFixture {
TEST_CASE(const97);
TEST_CASE(const98);
TEST_CASE(const99);
TEST_CASE(const100);

TEST_CASE(const_handleDefaultParameters);
TEST_CASE(const_passThisToMemberOfOtherClass);
Expand Down Expand Up @@ -6855,6 +6856,15 @@ class TestClass : public TestFixture {
ASSERT_EQUALS("", errout_str());
}

void const100() {
checkConst("struct S {\n" // #14023
" void f() { ++i; }\n"
" void f() const {}\n"
" int i;\n"
"};\n");
ASSERT_EQUALS("", errout_str());
}

void const_handleDefaultParameters() {
checkConst("struct Foo {\n"
" void foo1(int i, int j = 0) {\n"
Expand Down