Keep comments

[osesov]

Keep comments in the main text, not only in defines

[danmar]

@osesov @firewave I don't feel I understand the removeComments. please share your thoughts.

It says:

    bool removeComments; /** remove comment tokens from included files */

why would somebody want to remove comment tokens in included files but keep them in source file?

why is comment tokens added at all to the token list if removeComments is true.

it is not clear to me that we want to have comments in the preprocessor output at all. It's not clear to me if all macro expansions will work fine if there are comments kept.. i.e.:

#define XY(X,Y)    X /*a*/ ## /*b*/ Y

[danmar]

Cppcheck needs to be able to fetch comments. But off the top of my head it fetches the comments from the "raw tokenlists". cppcheck does not expect comment tokens in the "preprocess" output if I am not mistaken.

[osesov]

Natural behaviour of C preprocessor is to remove all comments. GCC's cpp allows -C flag to keep comments in the source code (also there is -CC flag, but this is out of scope).

Current behaviour of simplecpp is that:

If DUI::removeComments flag is true all the comments are removed. Just as expected. The comment you quoting seems to be misleading: comments are removed both from the main file and all the included files.

When DUI::removeComments is false, when some comments are removed, while some are kept: code keeps comments, coming from macro bodies, but ignores the comments coming from text (regardless whether it is main file or included file).

Taking this as example:

#define A 1 /* macro comment */
A /* text comment */

with 'DUI::removeComments = false` it will be expanded to (note that text comment has disappeared):

1 /* macro comment */

This commit would result in following:

1 /* macro comment */ /* text comment */

[osesov]

#define XY(X,Y)    X /*a*/ ## /*b*/ Y

you right these expansion do not work. No reason to apply this change then.