migrate the cke config into a field for nested fields too (when going from cms 4 to 5)#539
Merged
brandonkelly merged 2 commits into5.xfrom Mar 18, 2026
Merged
Conversation
… from cms 4 to 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you’re upgrading from cms v4 to v5 at the same time as cke plugin v3 to v5, the cms migrations will cause the nested CKEditor fields to have their settings semi-updated before the
m260220_182920_drop_cke_configsmigration has a chance to do its thing.By the time
m260220_182920_drop_cke_configsstarts, some of the field’s settings, likeckeConfig, are lost from the working project config. In such a case, we need to get the field’s settings directly from the database (not from project config and not from theFields->_fieldsmemoized array) and work with that set of settings.Related issues