[6.x] Form component compatibility - #19665
Draft
lukeholder wants to merge 21 commits into
Draft
lukeholder wants to merge 21 commits into
lukeholder wants to merge 21 commits into
Conversation
… component to start expanded
riasvdv
reviewed
Sep 21, 2026
| * using {@see self::labelField()}/{@see self::valueField()} (default `name`/`id`) to build its | ||
| * label/value. | ||
| */ | ||
| class ComboboxCreate extends Combobox |
Contributor
There was a problem hiding this comment.
Should this really be a separate component from the Combobox? @brianjhanson what do you think?
Contributor
There was a problem hiding this comment.
I'd say the same component. Ideally, I don't think the Combobbox needs to know it has a "Create" option at all. I'd say the option itself should be able to carry all this functionality and then the developer can just add that specific option into a regular combobox
…usage-updates # Conflicts: # resources/js/bootstrap/cp.ts # resources/js/modules/forms/register.ts # resources/js/modules/settings/composables/useSettingsSave.ts # resources/js/pages/Form.vue
📚 Storybook previews@craftcms/ui — open Storybook Changed components: resources/js — open Storybook No changed components detected in this Storybook. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various fixes and restoration of functionality for Tables and other form components that existed in 5.x