Skip to content

Rename action type to APPROVE_PUBLISH_PACKAGE for consistency#3965

Open
jmendeza wants to merge 1 commit into
craftercms:developfrom
jmendeza:feature/8770
Open

Rename action type to APPROVE_PUBLISH_PACKAGE for consistency#3965
jmendeza wants to merge 1 commit into
craftercms:developfrom
jmendeza:feature/8770

Conversation

@jmendeza

@jmendeza jmendeza commented Jul 15, 2026

Copy link
Copy Markdown
Member

Rename action type to APPROVE_PUBLISH_PACKAGE for consistency
craftercms/craftercms#8770

Summary by CodeRabbit

  • Audit Logging
    • Approval actions for publish packages are now recorded with a dedicated audit operation.
    • Legacy generic approval and rejection operation labels have been removed from the available operation set.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The audit log constants replace legacy approval and rejection operations with a publish-package approval operation. The package approval workflow passes this new operation to review processing, while imports are made explicit and reorganized.

Changes

Publish package audit operation

Layer / File(s) Summary
Audit operation constants
src/main/java/org/craftercms/studio/api/v2/dal/AuditLogConstants.java
Removes OPERATION_APPROVE and OPERATION_REJECT, and adds OPERATION_APPROVE_PUBLISH_PACKAGE.
Approval workflow integration
src/main/java/org/craftercms/studio/impl/v2/service/workflow/internal/WorkflowServiceInternalImpl.java
Uses explicit operation and state imports, reorganizes imports, and passes OPERATION_APPROVE_PUBLISH_PACKAGE from approvePackages to doReviewPackage.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • craftercms/craftercms#8770 — Requests changing the approval audit operation from APPROVE to APPROVE_PUBLISH_PACKAGE, matching this implementation.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: renaming the approval action to APPROVE_PUBLISH_PACKAGE.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jmendeza jmendeza marked this pull request as ready for review July 15, 2026 15:33
@jmendeza jmendeza requested a review from sumerjabri as a code owner July 15, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant