Skip to content

Fix deprecated validation on container (List)#3966

Open
jmendeza wants to merge 1 commit into
craftercms:support/4.xfrom
jmendeza:bug/8743-4x
Open

Fix deprecated validation on container (List)#3966
jmendeza wants to merge 1 commit into
craftercms:support/4.xfrom
jmendeza:bug/8743-4x

Conversation

@jmendeza

Copy link
Copy Markdown
Member

craftercms/craftercms#8743
Fix deprecated validation on container (List)

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The deleteUserProperties endpoint now applies @Valid to each properties list element while retaining @NotEmpty on the list and @NotBlank on its string values.

Changes

User property validation

Layer / File(s) Summary
Apply validation to list elements
src/main/java/org/craftercms/studio/controller/rest/v2/UsersController.java
Moves @Valid from the list parameter to each contained string value in deleteUserProperties.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: updating validation on a List container.
Description check ✅ Passed The description is directly related to the validation fix in the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jmendeza

Copy link
Copy Markdown
Member Author

@coderabbitai is this ready to move forward?

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
gh pr view 3966 --repo craftercms/studio --json title,body,state,mergeable,mergeStateStatus,reviews,statusCheckRollup,comments 2>&1 | head -300

Length of output: 7011


@jmendeza Not quite yet — a couple of things to flag before this can move forward:

  1. CodeRabbit's review hasn't actually run yet — my earlier attempt hit the org's PR review rate limit, so no substantive review has been posted on the code changes.
  2. CI is currently failing/blocked:
    • Travis CI - Pull Request: FAILURE
    • Codacy Static Code Analysis: ACTION_REQUIRED
    • GitGuardian Security Checks: SUCCESS
    • Overall merge state is BLOCKED.

I'd recommend checking the Travis CI build log and the Codacy findings before merging. I'll go ahead and trigger a full review now so you get actual feedback on the code changes.

✅ Action performed

Full review finished.

@jmendeza jmendeza marked this pull request as ready for review July 15, 2026 18:04
@jmendeza jmendeza requested a review from sumerjabri as a code owner July 15, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant