Fix sa.Time() raising Cannot find data type: time on CrateDB

[florinutz]

CrateTypeCompiler had no visit_time, so sa.Time fell through to SQLAlchemy's generic compiler and emitted SQL-standard TIME. CrateDB has no storable time-of-day type: plain TIME doesn't exist, and TIME WITH TIME ZONE (TIMETZ) is literal/cast-only ("does not support storage"). sa.Date/sa.DateTime worked only because they already had overrides mapping to TIMESTAMP.

Closes #206.

Fix

Storing time-of-day as a STRING in ISO 8601 format — the same convention the crate driver already uses for datetime.time (see crate/crate-python#696):

A datetime.time now round-trips intact, including tz-aware values.

Tests

• tests/create_table_test.py: DDL renders STRING instead of TIME
• tests/datetime_test.py: live round-trip of a datetime.time

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61dad7af-352e-4efb-b18b-31fa420c0756

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-206-sa-time

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bgunebakan]

Thank you! I've added some comments.

[bgunebakan]

Thank you!