[Fix] Tuple::compare use strcmp instead of spaceship operator (#53) - #57
Merged
Conversation
Refs: #53 Replace the spaceship operator (<=>) with strcmp() for byte-wise comparison of packed tuple data. PHP's <=> can coerce numeric-looking strings, which is a latent correctness footgun. strcmp() compares byte-by-byte and the result is normalized to -1/0/1. Adds compareNumericLookingStrings test to verify correct ordering of bytes that look like numeric strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53.
Replace the spaceship operator (
$packed1 <=> $packed2) withstrcmp($packed1, $packed2) <=> 0for byte-wise comparison of packed tuple data. PHP's<=>can coerce numeric-looking strings (numeric-string coercion), which is a latent correctness footgun.strcmp()compares byte-by-byte and the result is normalized to -1/0/1.Changes
return $packed1 <=> $packed2toreturn strcmp($packed1, $packed2) <=> 0compareNumericLookingStrings()test that verifies correct ordering of bytes that look like numeric strings, plus equality and regular string orderingVerification
Acceptance Criteria