fix: FutureStringArray::await() returns dangling CData instead of owned PHP strings (#36) - #60
Merged
Conversation
…ng CData (#36) Use FFI::string() to copy char* elements into owned PHP strings before the future's memory is released. Previously, raw FFI\CData pointers were returned and became dangling after releaseMemory(), causing use-after-free in getAddressesForKey() and any other consumer. Also strengthens the getAddressesForKey integration test to verify that returned elements are real strings matching host:port format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FutureStringArray::await()indexeschar**directly ([]), which returns anFFI\CDatapointer — not a PHP string. AfterreleaseMemory()those pointers become dangling (use-after-free). This is the public path behindReadTransaction::getAddressesForKey().Fix
Replaced raw
char*indexing withFFI::string()to copy each element into an owned PHP string before the future's memory is released — same pattern already used inFutureKeyArray::await().Changes
src/Future/FutureStringArray.phpFFI::string([])instead of raw pointer assignmenttests/Integration/BasicCrudTest.phpgetAddressesForKey()test now verifies elements are real strings matchinghost:portformatCHANGELOG.mdVerification
Closes #36