fix: correct KeyValueLimitTest error codes and size calculations - #62
Merged
Conversation
added 2 commits
July 3, 2026 23:49
- Use client-side error codes 2102/2103 instead of server-side 2203/2204 - Account for key byte overhead in transactionAtDefaultSizeLimitSucceeds - Remove fragile message string assertions (FDB returns 'exceeds', not 'large')
- Add & 0xFF bitmask to chr() calls to satisfy int<0,255> constraint - Lines 215, 244: TYPE_INT_ZERO arithmetic guaranteed in range but PHPStan can't prove it statically - Line 313: XOR with 0xFF always produces 0-255 but PHPStan doesn't track it - Line 759: hexdec of 2-char substring always produces 0-255
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 6 pre-existing failures in KeyValueLimitTest:
largebut FDB saysTransaction exceeds byte limit