fix: warn on deprecated index creation methods (closes #169) - #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #169
Changes
E_USER_DEPRECATEDfrom the four deprecated index-creation wrappers in the PHP FFI implementation.createIndex()plusZVecIndexParamsfactory.createIndex()deprecation messages in existing tests that intentionally exercise legacy wrappers.CHANGELOG.mdUnreleased.Testing
php run-tests.php -n -d ffi.enable=1 tests/— 172 passed, 2 expected XFAIL, 2 platform/feature skipsgit diff --checktest_dbs/cleanedCode Review
The native PHP extension is intentionally unchanged: it does not expose the unified
createIndex()/ZVecIndexParamsAPI or the HNSW-RaBitQ legacy wrapper; the change is explicitly scoped to the FFI implementation.