fix(tests): reset middleware order header per request (closes #533) - #545
Merged
Conversation
6 tasks
…eware-triple-dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #533
Changes
MiddlewareTest::testHeadersno longer sees a staleX-Test-Middleware-request-ordervalue on subsequent keep-alive requests under macOS / WorkermantestMiddlewareRequestHeadersDoNotLeakAcrossRequests) that performs two consecutive requests through the same HTTP client and asserts identical middleware order on both responsesRoot cause
The test middleware (
TestMiddleware) accumulated theX-Test-Middleware-request-orderheader across keep-alive requests because the request header state was never reset at the start of each request. On macOS / Workerman the second request received the accumulated value, causingtestHeadersto see the chain 3× instead of 1×.Changelog
Code Review