fix: lazy inotify directory watches for fast startup (closes #324) - #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #324
Changes
Worker::$globalEvent->delay()after the event loop startswatchedPathsreverse-lookup map for O(1) duplicate detectionpathByWdcleanup on IN_IGNORED now also removes the path fromwatchedPathstestStartWatchesOnlyTopLevelDirectories(wastestStartRecursivelyWatchesDirectories), addedtestDeferredWalkWatchesAllSubdirectories, and updated event-loop mocksChangelog
Performance: Optimize InotifyMonitorWatcher startup by deferring the recursive directory walk to after the event loop starts, eliminating synchronous full-directory walk on very large source trees.
Code Review