Skip to content

fix(http): prevent cached request header leakage (closes #576) - #599

Merged
s2x merged 2 commits into
masterfrom
fix/issue-576-request-header-cache-leak
Jul 28, 2026
Merged

fix(http): prevent cached request header leakage (closes #576)#599
s2x merged 2 commits into
masterfrom
fix/issue-576-request-header-cache-leak

Conversation

@s2x

@s2x s2x commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #576

Changes

  • Restore parsed request headers after every handler dispatch, including when the handler throws.
  • Prevent middleware mutations from persisting in Workerman's request cache.
  • Add regression coverage for normal and exceptional handler paths.
  • Update security documentation and changelog.

Verification

  • composer lint
  • composer test
  • Code review completed; no blocker findings

Code Review

  • Passed subagent code review
  • All review comments addressed

@s2x s2x self-assigned this Jul 27, 2026
@s2x
s2x merged commit 1911fb7 into master Jul 28, 2026
12 checks passed
@s2x
s2x deleted the fix/issue-576-request-header-cache-leak branch July 28, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Middleware setHeader() mutations persist into Workerman's request cache and are replayed to later requests

1 participant