Skip to content

test: silence expected failure diagnostics - #604

Merged
s2x merged 1 commit into
masterfrom
fix/silent-test-output
Jul 30, 2026
Merged

test: silence expected failure diagnostics#604
s2x merged 1 commit into
masterfrom
fix/silent-test-output

Conversation

@s2x

@s2x s2x commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Keep expected exception and warning diagnostics out of the PHPUnit progress output without changing production logging or error handling.

Changes

  • Capture the expected ServerWorker backstop log in a temporary file.
  • Use NullLogger for HttpRequestHandler tests that verify 500/error-path behavior rather than logging.
  • Suppress only the expected mkdir(): Not a directory warning in the directory-failure test.
  • Keep dedicated tests that verify error_log() fallback behavior unchanged.

Validation

  • composer lint
  • composer test

Changelog

No changelog entry: this is test-only and does not change library behavior.

Code Review

  • Local diff review completed
  • All local lint and test checks pass

@s2x
s2x merged commit 0e11540 into master Jul 30, 2026
12 checks passed
@s2x
s2x deleted the fix/silent-test-output branch July 30, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant