fix(security): unify SFX redirect policy across modes (closes #585) - #606
Merged
Conversation
added 4 commits
August 4, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #585
HTTPS→HTTP downgrade redirects were blocked only when
--insecurewas passed; the default path handed redirect following to PHP'shttpwrapper, which follows a downgrade to plain HTTP without complaint. The hardening was attached to the wrong branch.Changes
follow_location => 0in both modes: PHP's http wrapper never follows a redirect on the bundle's behalffile://,php://,ftp://) are blocked from every origin schemeresolveRedirectUrl()hardened: unresolvable base URLs and non-HTTP(S) absolute locations throw instead of passing through; protocol-relative locations resolve correctlyHTTP:///HTTPS://URLs and Location headers cannot bypass the policySfxDownloader::__construct($maxDownloadBytes)); oversized downloads abort and remove the partial fileZipArchiveruns; for.zipURLs the checksum now covers the zip artifactwriteStream(): short writes are detected and the partial artifact is cleaned upChangelog
Entry added under [Unreleased] → Security.
Code Review