fix: strip File objects from messages for non-multimodal LLMs#4536
Open
hztBUAA wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: strip File objects from messages for non-multimodal LLMs#4536hztBUAA wants to merge 1 commit intocrewAIInc:mainfrom
hztBUAA wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
When an LLM does not support multimodal inputs (e.g. Ollama/Gemma 3), _process_message_files() returned early without removing the `files` key from messages. The File objects (not JSON-serializable) then flowed through to the OpenAI SDK, causing: TypeError: Object of type File is not JSON serializable Now the `files` key is always stripped from messages, regardless of whether the LLM supports multimodal. This ensures messages are always JSON-serializable when passed to any provider's API client. Fixes crewAIInc#4498
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Object of type File is not JSON serializablewhen usinginput_fileswith LLMs that don't support multimodal (e.g., Ollama/Gemma 3)BaseLLM._process_message_files()returned early for non-multimodal LLMs without removing thefileskey from messages, leaving non-serializableFileobjects in the message dicts that get passed tojson.dumps()by the httpx clientfileskey from all messages when multimodal is not supported, before returningTest plan
TestProcessMessageFilesclass covering:fileskey from messagesfileskey are unaffectedfilesafter converting to content blocksFixes #4498