fix: strip trailing whitespace from assistant messages for Anthropic#4538
Open
hztBUAA wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: strip trailing whitespace from assistant messages for Anthropic#4538hztBUAA wants to merge 1 commit intocrewAIInc:mainfrom
hztBUAA wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
Anthropic API returns 400 BadRequestError when the final assistant message content ends with trailing whitespace. This fix strips trailing whitespace in both code paths: - LLM._format_messages_for_provider (litellm path) - AnthropicCompletion._format_messages_for_anthropic (direct SDK path) Handles both plain string content and structured content blocks (e.g. thinking + text). Closes crewAIInc#4413
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4413
Anthropic API returns a
400 BadRequestErrorwhen the final assistant message content ends with trailing whitespace:This PR strips trailing whitespace from the final assistant message before sending the request to Anthropic, in both code paths:
LLM._format_messages_for_provider— the litellm path, where Anthropic models are detected viaself.is_anthropicAnthropicCompletion._format_messages_for_anthropic— the direct Anthropic SDK path, handling both plain string content and structured content blocks (e.g. thinking + text)Test plan
test_anthropic_strips_trailing_whitespace_from_final_assistant_messagecovering:test_anthropic_message_formatting_edge_casesstill passes