Skip to content

Add new Signatures webhook event information#314

Merged
haysch merged 2 commits intomasterfrom
signatures/webhook_all-current-signatories-signed
Apr 16, 2026
Merged

Add new Signatures webhook event information#314
haysch merged 2 commits intomasterfrom
signatures/webhook_all-current-signatories-signed

Conversation

@haysch
Copy link
Copy Markdown
Contributor

@haysch haysch commented Apr 16, 2026

Document the new ALL_CURRENT_SIGNATORIES_SIGNED event.

@haysch haysch requested a review from mickhansen April 16, 2026 09:20
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 16, 2026

Deploy Preview for criipto-docs ready!

Name Link
🔨 Latest commit 6a6099e
🔍 Latest deploy log https://app.netlify.com/projects/criipto-docs/deploys/69e0acdaa0c37700082f9846
😎 Deploy Preview https://deploy-preview-314--criipto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

```text
{
"event" = "ALL_CURRENT_SIGNATORIES_SIGNED",
"signatoryIds" = [ "[GraphQL ID]" ],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the best way to define a list of IDs.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"signatoryIds" = ["[GraphQL ID]", ..."[GraphQL ID]"] maybe?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double brackets are a little annoying to read though

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should switch to something like ${signatoryId}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also what I was beginning to think - or maybe just {SignatoryId} without the dollar-sign?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haysch Yeah also an option :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickhansen amended.

haysch added 2 commits April 16, 2026 11:31
Rather than having the vague `[GraphQL ID]`, which could also be read as
a list of elements, we explicitly declare what the variable kind is.
Document the new `ALL_CURRENT_SIGNATORIES_SIGNED` event.
@haysch haysch force-pushed the signatures/webhook_all-current-signatories-signed branch from 758c625 to 6a6099e Compare April 16, 2026 09:33
@haysch haysch merged commit 0cf2ce6 into master Apr 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants