Skip to content

Add analyzer detecting let! _ = ... .#12

Open
fkj wants to merge 2 commits intomasterfrom
add-let-wildcard-result-analyzer
Open

Add analyzer detecting let! _ = ... .#12
fkj wants to merge 2 commits intomasterfrom
add-let-wildcard-result-analyzer

Conversation

@fkj
Copy link
Copy Markdown
Collaborator

@fkj fkj commented Nov 21, 2025

This detects a pattern that makes it easy to accidentally introduce subtle security bugs.

@fkj
Copy link
Copy Markdown
Collaborator Author

fkj commented Nov 21, 2025

Results of running on the Verify solution

64 occurrences detected, none of which were false positives.
Most occurrences were in test code or in the management API. Most occurrences were validation code which is the target of the analyzer.
Almost of the occurrences look like they could be fixed with minor rewrites.

This detects a pattern that makes it easy to accidentally introduce
subtle security bugs.
@fkj fkj force-pushed the add-let-wildcard-result-analyzer branch from ce37335 to f3795cd Compare February 24, 2026 13:31
@fkj fkj marked this pull request as ready for review March 12, 2026 15:14
@fkj fkj requested a review from kasperhj March 12, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant