Show banner and log node module load failures when registry is empty#19
Open
Show banner and log node module load failures when registry is empty#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NODE_DEFSafter node registration attempts.Description
loadNodesFromList()and theentriesmanifest loader and accumulates them via afailuresarray andrecordFailurehelper inloadNodes().Object.keys(NODE_DEFS).length === 0after all loading attempts, injects a small banner into the top bar (or falls back to the left panel head) with the message: "Node registry empty — open DevTools Console." and styles it for visibility.console.errorfor each recorded failure with the module name and associated error when the registry is empty.nodeRegistry.loadedbased on the final node count.Testing
Codex Task