fix(extension): prevent idle Flow tab leaks - #44
Open
Bl0ck154 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a tab leak in the MV3 extension that can accumulate many
flow.google.comtabs even while no generation is running.Root causes
token-refreshalarm could create a Flow tab when none was open;labs.google/.../flowURL redirects toflow.google.com, stale deployments can repeatedly decide that no usable Flow tab exists;Changes
fresh[0]from a re-query;flow.google.comhost support to the agent health state;flow.google.cominstead of the legacy labs URL;Validation
node --test tests/extension_mv3_bootstrap.test.cjspasses on this branch.agent/services/flow_client.pycompiles cleanly.The self-hosted CRX deployment/idle-browser parking pieces used by my deployment are intentionally not included in this PR, so this stays focused on upstream-portable behavior.