fix: added missing datasources and plugins when creating a new Grafana project#530
Conversation
jpsfs
left a comment
There was a problem hiding this comment.
I have my doubts if we should make this standard.
The data sources are part of the Product's Grafana and I'm not sure we want each App to have their own Grafana instance. Running costs will continue to pile up. We should at least take this to Architecture meeting.
|
While I agree with you, right now the model is the one where each app has its own grafana instance. We are trying to minimize the amount of manual steps when creating a new app, so this PR would help in that sense. As I see it there are two different issues, in the context of this PR we only need to evaluate if it makes sense to have these datasources provided by default when scaffolding a new app, since in the current architecture the app has access and uses the Product stack components. If in the future the architecture changes, we need to make the necessary adjustments. |
|
Hi Miguel, Not all apps will require dashboards I suppose (the fact that the ones we've made so far needed, is not a reference for the future). And these are the things that are hard to come back from. If tomorrow we take Grafana out, then we have a large set of users complaining that there is a feature that got lost. My request is that we look at all the components holistically and make sure we define what should be framework components and what should be app components - if the decision is that each app should use their Grafana instance (if needed), which might be the only course of action if apps want to use different plugins and components, I'm OK with it. |
ad30aac to
6dbfba8
Compare
6dbfba8 to
1277020
Compare
| type: retrodaredevil-wildgraphql-datasource | ||
| uid: PCqMAq1QX | ||
| access: proxy | ||
| url: http://traefik:8082/datamanager/cube/graphql |
There was a problem hiding this comment.
these hardcoded port numbers imply some knowledge of the internal stack/container structure. Can't we avoid this? ideally we should only trust the official API paths in the external ingress
This PR adds missing datasources and plugins when scaffolding a new Grafana project.
These plugins allow Grafana to make queries via OData and GraphQL.