Skip to content

fix: added missing datasources and plugins when creating a new Grafana project#530

Draft
goncaloo23 wants to merge 2 commits intocriticalmanufacturing:developmentfrom
goncaloo23:development-add-datasources-to-grafana-during-scaffolding
Draft

fix: added missing datasources and plugins when creating a new Grafana project#530
goncaloo23 wants to merge 2 commits intocriticalmanufacturing:developmentfrom
goncaloo23:development-add-datasources-to-grafana-during-scaffolding

Conversation

@goncaloo23
Copy link
Copy Markdown
Contributor

This PR adds missing datasources and plugins when scaffolding a new Grafana project.
These plugins allow Grafana to make queries via OData and GraphQL.

@goncaloo23 goncaloo23 changed the base branch from main to development June 24, 2025 16:43
Copy link
Copy Markdown
Contributor

@jpsfs jpsfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my doubts if we should make this standard.
The data sources are part of the Product's Grafana and I'm not sure we want each App to have their own Grafana instance. Running costs will continue to pile up. We should at least take this to Architecture meeting.

@migafgarcia
Copy link
Copy Markdown
Contributor

migafgarcia commented Jun 25, 2025

While I agree with you, right now the model is the one where each app has its own grafana instance. We are trying to minimize the amount of manual steps when creating a new app, so this PR would help in that sense.

As I see it there are two different issues, in the context of this PR we only need to evaluate if it makes sense to have these datasources provided by default when scaffolding a new app, since in the current architecture the app has access and uses the Product stack components.

If in the future the architecture changes, we need to make the necessary adjustments.

@goncaloo23 goncaloo23 marked this pull request as draft June 25, 2025 11:01
@jpsfs
Copy link
Copy Markdown
Contributor

jpsfs commented Jun 26, 2025

Hi Miguel,

Not all apps will require dashboards I suppose (the fact that the ones we've made so far needed, is not a reference for the future). And these are the things that are hard to come back from. If tomorrow we take Grafana out, then we have a large set of users complaining that there is a feature that got lost.

My request is that we look at all the components holistically and make sure we define what should be framework components and what should be app components - if the decision is that each app should use their Grafana instance (if needed), which might be the only course of action if apps want to use different plugins and components, I'm OK with it.

@goncaloo23 goncaloo23 marked this pull request as ready for review June 27, 2025 15:15
@goncaloo23 goncaloo23 force-pushed the development-add-datasources-to-grafana-during-scaffolding branch 3 times, most recently from ad30aac to 6dbfba8 Compare June 27, 2025 15:53
@goncaloo23 goncaloo23 closed this Jun 27, 2025
@goncaloo23 goncaloo23 force-pushed the development-add-datasources-to-grafana-during-scaffolding branch from 6dbfba8 to 1277020 Compare June 27, 2025 15:58
@goncaloo23 goncaloo23 reopened this Jun 27, 2025
@goncaloo23 goncaloo23 changed the title Added missing datasources and plugins when creating a new Grafana project fix: added missing datasources and plugins when creating a new Grafana project Jun 27, 2025
type: retrodaredevil-wildgraphql-datasource
uid: PCqMAq1QX
access: proxy
url: http://traefik:8082/datamanager/cube/graphql
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these hardcoded port numbers imply some knowledge of the internal stack/container structure. Can't we avoid this? ideally we should only trust the official API paths in the external ingress

@goncaloo23 goncaloo23 marked this pull request as draft July 7, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants